[Imgcif-l] Fwd: Re: Possible bug in cbf_byte_offset.c

Thu Feb 18 17:43:11 GMT 2010

Dear Graeme,

   Yup.  I agree.  I am working on a see-saw image to cover a very wide range of
both positive and negative delta's tp try to flush out any other such
bugs.  I would appreciate your 128x128, but I also want to do a much
larger one to catch the 32 bit image cases.

   Regards,
     Herbert
At 11:06 AM -0500 2/18/10, Herbert J. Bernstein wrote:
>To: <imgcif-l at iucr.org>, <nksauter at lbl.gov>
>X-OriginalArrivalTime: 18 Feb 2010 15:57:03.0450 (UTC)
>	FILETIME=[034D1BA0:01CAB0B3]
>X-Assp-Delay: not delayed (whitebox 93.95.13.253); 18 Feb 2010 16:05:47 +0000
>X-Assp-Message-Score: -15 (In Penalty White Box)
>X-Assp-Envelope-From: Graeme.Winter at Diamond.ac.uk
>Subject: Re: [Imgcif-l] Possible bug in cbf_byte_offset.c
>X-BeenThere: imgcif-l at iucr.org
>X-Mailman-Version: 2.1.9
>Precedence: list
>Reply-To: The Crystallographic Binary File and its imgCIF 
>application to image data <imgcif-l at iucr.org>
>List-Id: The Crystallographic Binary File and its imgCIF application to image
>	data <imgcif-l.iucr.org>
>List-Unsubscribe: <http://scripts.iucr.org/mailman/listinfo/imgcif-l>,
>	<mailto:imgcif-l-request at iucr.org?subject=unsubscribe>
>List-Archive: <http://scripts.iucr.org/pipermail/imgcif-l>
>List-Post: <mailto:imgcif-l at iucr.org>
>List-Help: <mailto:imgcif-l-request at iucr.org?subject=help>
>List-Subscribe: <http://scripts.iucr.org/mailman/listinfo/imgcif-l>,
>	<mailto:imgcif-l-request at iucr.org?subject=subscribe>
>Content-Type: text/plain; charset="us-ascii"
>Content-Transfer-Encoding: 7bit
>Sender: imgcif-l-bounces at iucr.org
>Errors-To: imgcif-l-bounces at iucr.org
>
>Dear Herbert,
>
>Surely it would be relatively straightforward to "fake" some
>pathalogical images for the purposes of testing, i.e. set values of
>0xffff, 0x0000, 0xffff, 0x0000 &c. in a "C" array and compress this to a
>CBF stream?
>
>As you could have a valid CBF 128 x 128 pixels (say) it needn't be that
>large even... If I get a quiet moment I'll code something up.
>
>Best wishes,
>
>Graeme
>
>-----Original Message-----
>From: imgcif-l-bounces at iucr.org [mailto:imgcif-l-bounces at iucr.org] On
>Behalf Of Herbert J. Bernstein
>Sent: 18 February 2010 04:21
>To: Nicholas K. Sauter
>Cc: imgcif-l at iucr.org
>Subject: Re: [Imgcif-l] Possible bug in cbf_byte_offset.c
>
>Dear Nick,
>
>    You are absolutely right.  I am also having trouble working up a test
>case.  It needs an image with a very large negative delta.   I'll try
>to force something.
>
>    In the meantime, I have updated the sourceforge cbflib svn with the
>fix in CBFlib_bleeding_edge.  After I have a test case, I'll propagate
>the change more widely.
>
>    I am copying this to the imgCIF list to warn others in the meantime.
>
>    Thank you very much.  Well done.
>
>    Regards,
>      Herbert
>
>
>
>
>At 11:06 AM -0800 2/17/10, Nicholas K. Sauter wrote:
>>Herbert,
>>
>>Please see line 1166 in src/cbf_byte_offset.c.
>>
>>Based on the logic of the algorithm I think this line should be
>>
>>if (delta[0] & 0x8000) {
>>
>>i.e., there is an extra "0" in the hex value in the CVS code.
>>That being said, I don't think this line has an effect on any of my
>>test cases, so I'm at a loss about how to test this out.
>>
>>Nick
>
>
>--
>=====================================================
>   Herbert J. Bernstein, Professor of Computer Science
>     Dowling College, Kramer Science Center, KSC 121
>          Idle Hour Blvd, Oakdale, NY, 11769
>
>                   +1-631-244-3035
>                   yaya at dowling.edu
>=====================================================
>_______________________________________________
>imgcif-l mailing list
>imgcif-l at iucr.org
>http://scripts.iucr.org/mailman/listinfo/imgcif-l
>
>--
>This e-mail and any attachments may contain confidential, copyright 
>and or privileged material, and are for the use of the intended 
>addressee only. If you are not the intended addressee or an 
>authorised recipient of the addressee please notify us of receipt by 
>returning the e-mail and do not use, copy, retain, distribute or 
>disclose the information in or attached to the e-mail.
>Any opinions expressed within this e-mail are those of the 
>individual and not necessarily of Diamond Light Source Ltd.
>Diamond Light Source Ltd. cannot guarantee that this e-mail or any 
>attachments are free from viruses and we cannot accept liability for 
>any damage which you may sustain as a result of software viruses 
>which may be transmitted in or with the message.
>Diamond Light Source Limited (company no. 4375679). Registered in 
>England and Wales with its registered office at Diamond House, 
>Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 
>0DE, United Kingdom
>
>
>
>
>_______________________________________________
>imgcif-l mailing list
>imgcif-l at iucr.org
>http://scripts.iucr.org/mailman/listinfo/imgcif-l

-- 
=====================================================
  Herbert J. Bernstein, Professor of Computer Science
    Dowling College, Kramer Science Center, KSC 121
         Idle Hour Blvd, Oakdale, NY, 11769

                  +1-631-244-3035
                  yaya at dowling.edu
=====================================================